Ufdjrw

I'm trying to make an array of structs where each struct represents a celestial body.

I don't have that much experience with structs, which is why I decided to try to use them instead of a whole bunch of arrays. However, I keep on running into numerous different errors. I've tried to implement the techniques that I've seen on various threads and on StackOverflow (such as Array of structs in C and C - initialize array of structs), however not all of them were applicable.

Further information for those who have read this far: I don't need any of this to be dynamic, I know/define the size of everything beforehand. I also need this to be a global array as I'm accessing this in several different methods which have defined arguments (i.e. GLUT methods).

This is how I'm defining the struct in my header:

struct body

 double p[3];//position
 double v[3];//velocity
 double a[3];//acceleration
 double radius;
 double mass;
;

I have a list of other global variables that I'm defining before I define the interior of the struct, and one of those is the array of this struct (basically, if I'm being too unclear in my fogged speak, the line below is above the stuff above):

struct body bodies[n];

Just so you know, n is something that I've legitimately defined (i.e. #define n 1).

I use this array in several different methods, but the easiest and least space consuming one is a simplified form of my main. Here I initialize all of the variables in each of the structs, just to set the variables for certain before I modify them in some way:

 int a, b;
 for(a = 0; a < n; a++)
 
 for(b = 0; b < 3; b++)
 
 bodies[a].p[b] = 0;
 bodies[a].v[b] = 0;
 bodies[a].a[b] = 0;
 
 bodies[a].mass = 0;
 bodies[a].radius = 1.0;
 

The current error that I'm facing is nbody.c:32:13: error: array type has incomplete element type where line 32 is where I'm making the array of the structs.

One last clarification, by header I mean the space above int main(void) but in the same *.c file.

#include<stdio.h>
#define n 3
struct body

 double p[3];//position
 double v[3];//velocity
 double a[3];//acceleration
 double radius;
 double mass;
;

struct body bodies[n];

int main()

 int a, b;
 for(a = 0; a < n; a++)
 
 for(b = 0; b < 3; b++)
 
 bodies[a].p[b] = 0;
 bodies[a].v[b] = 0;
 bodies[a].a[b] = 0;
 
 bodies[a].mass = 0;
 bodies[a].radius = 1.0;
 

 return 0;

this works fine. your question was not very clear by the way, so match the layout of your source code with the above.

I think you could write it that way too. I am also a student so I understand your struggle. A bit late response but ok .

#include<stdio.h>
#define n 3

struct 
 double p[3];//position
 double v[3];//velocity
 double a[3];//acceleration
 double radius;
 double mass;
bodies[n];

move

struct body bodies[n];

to after

struct body

 double p[3];//position
 double v[3];//velocity
 double a[3];//acceleration
 double radius;
 double mass;
;

Rest all looks fine.

So to put it all together by using malloc():

int main(int argc, char** argv) 
 typedef struct
 char* firstName;
 char* lastName;
 int day;
 int month;
 int year;

 STUDENT;

 int numStudents=3;
 int x;
 STUDENT* students = malloc(numStudents * sizeof *students);
 for (x = 0; x < numStudents; x++)
 students[x].firstName=(char*)malloc(sizeof(char*));
 scanf("%s",students[x].firstName);
 students[x].lastName=(char*)malloc(sizeof(char*));
 scanf("%s",students[x].lastName);
 scanf("%d",&students[x].day);
 scanf("%d",&students[x].month);
 scanf("%d",&students[x].year);
 

 for (x = 0; x < numStudents; x++)
 printf("first name: %s, surname: %s, day: %d, month: %d, year: %dn",students[x].firstName,students[x].lastName,students[x].day,students[x].month,students[x].year);

 return (EXIT_SUCCESS);

That error means that the compiler is not able to find the definition of the type of your struct before the declaration of the array of structs, since you're saying you have the definition of the struct in a header file and the error is in nbody.c then you should check if you're including correctly the header file.
Check your #include's and make sure the definition of the struct is done before declaring any variable of that type.

Solution using pointers:

#include<stdio.h>
#include<stdlib.h>
#define n 3
struct body

 double p[3];//position
 double v[3];//velocity
 double a[3];//acceleration
 double radius;
 double *mass;
;


int main()

 struct body *bodies = (struct body*)malloc(n*sizeof(struct body));
 int a, b;
 for(a = 0; a < n; a++)
 
 for(b = 0; b < 3; b++)
 
 bodies[a].p[b] = 0;
 bodies[a].v[b] = 0;
 bodies[a].a[b] = 0;
 
 bodies[a].mass = 0;
 bodies[a].radius = 1.0;
 

 return 0;