Ufdjrw

Only print output after finding pattern

If I blow insulation everywhere in my attic except the door trap, will heat escape through it?

Increase performance creating Mandelbrot set in python

Term for the "extreme-extension" version of a straw man fallacy?

How do I go from 300 unfinished/half written blog posts, to published posts?

Horror movie/show or scene where a horse creature opens its mouth really wide and devours a man in a stables

Why do professional authors make "consistency" mistakes? And how to avoid them?

How can I quit an app using Terminal?

Customer Requests (Sometimes) Drive Me Bonkers!

% symbol leads to superlong (forever?) compilations

Grabbing quick drinks

When Does an Atlas Uniquely Define a Manifold?

Robert Sheckley short story about vacation spots being overwhelmed

Are there languages with no euphemisms?

When airplanes disconnect from a tanker during air to air refueling, why do they bank so sharply to the right?

How to be diplomatic in refusing to write code that breaches the privacy of our users

WOW air has ceased operation, can I get my tickets refunded?

Does it take more energy to get to Venus or to Mars?

What is the point of a new vote on May's deal when the indicative votes suggest she will not win?

Why didn't Khan get resurrected in the Genesis Explosion?

Return the Closest Prime Number

What is the purpose of the Evocation wizard's Potent Cantrip feature?

Shade part of a Venn diagram

What does "Its cash flow is deeply negative" mean?

How to Set Up a Test for the Destroy Method Laravel 5.6

0

I'm going through the testing on my app, and I've gotten to the point where I need to test the destroy method of my controller. The test as I have it currently is:

public function test_user_can_delete_draft()

 $user = factory(User::class)->states('confirmed', 'normaluser')->create();
 $userForm = factory(Form::class)->states('in_house_signs')->create(['user_id' => $user->id, 'status' => 'draft',]);
 // Test creator can delete form
 $response = $this->actingAs($user)->delete(route('forms.destroy', $userForm));
 $response->assertSuccessful();

And the method in the controller that I am testing is:

public function destroy($id) 
 $form = Form::find($id);
 Comment::where('form_id', $id)->delete();
 $form->delete();

 // Redirect
 return redirect()->back()->with('status', 'Form successfully deleted');

When I run phpunit, I get the error:

Response status code [302] is not a successful status code.
Failed asserting that false is true.

What should I do to get the test to run properly?

php laravel laravel-5.6 laravel-testing

share|improve this question

asked Mar 7 at 14:29

Erik WillliamsErik Willliams

142

add a comment | 

0

I'm going through the testing on my app, and I've gotten to the point where I need to test the destroy method of my controller. The test as I have it currently is:

public function test_user_can_delete_draft()

 $user = factory(User::class)->states('confirmed', 'normaluser')->create();
 $userForm = factory(Form::class)->states('in_house_signs')->create(['user_id' => $user->id, 'status' => 'draft',]);
 // Test creator can delete form
 $response = $this->actingAs($user)->delete(route('forms.destroy', $userForm));
 $response->assertSuccessful();

And the method in the controller that I am testing is:

public function destroy($id) 
 $form = Form::find($id);
 Comment::where('form_id', $id)->delete();
 $form->delete();

 // Redirect
 return redirect()->back()->with('status', 'Form successfully deleted');

When I run phpunit, I get the error:

Response status code [302] is not a successful status code.
Failed asserting that false is true.

What should I do to get the test to run properly?

php laravel laravel-5.6 laravel-testing

share|improve this question

asked Mar 7 at 14:29

Erik WillliamsErik Willliams

142

add a comment | 

I'm going through the testing on my app, and I've gotten to the point where I need to test the destroy method of my controller. The test as I have it currently is:

public function test_user_can_delete_draft()

 $user = factory(User::class)->states('confirmed', 'normaluser')->create();
 $userForm = factory(Form::class)->states('in_house_signs')->create(['user_id' => $user->id, 'status' => 'draft',]);
 // Test creator can delete form
 $response = $this->actingAs($user)->delete(route('forms.destroy', $userForm));
 $response->assertSuccessful();

And the method in the controller that I am testing is:

public function destroy($id) 
 $form = Form::find($id);
 Comment::where('form_id', $id)->delete();
 $form->delete();

 // Redirect
 return redirect()->back()->with('status', 'Form successfully deleted');

When I run phpunit, I get the error:

Response status code [302] is not a successful status code.
Failed asserting that false is true.

What should I do to get the test to run properly?

php laravel laravel-5.6 laravel-testing

share|improve this question

asked Mar 7 at 14:29

Erik WillliamsErik Willliams

142

public function test_user_can_delete_draft()

 $user = factory(User::class)->states('confirmed', 'normaluser')->create();
 $userForm = factory(Form::class)->states('in_house_signs')->create(['user_id' => $user->id, 'status' => 'draft',]);
 // Test creator can delete form
 $response = $this->actingAs($user)->delete(route('forms.destroy', $userForm));
 $response->assertSuccessful();

public function destroy($id) 
 $form = Form::find($id);
 Comment::where('form_id', $id)->delete();
 $form->delete();

 // Redirect
 return redirect()->back()->with('status', 'Form successfully deleted');

Response status code [302] is not a successful status code.
Failed asserting that false is true.

share|improve this question

asked Mar 7 at 14:29

Erik WillliamsErik Willliams

142

share|improve this question

asked Mar 7 at 14:29

Erik WillliamsErik Willliams

142

asked Mar 7 at 14:29

Erik WillliamsErik Willliams

142

asked Mar 7 at 14:29

Erik WillliamsErik Willliams

142

2 Answers
2

active

oldest

votes

0

you could try to use assertRedirect https://laravel.com/docs/5.6/http-tests#assert-redirect

or use the status check:

$response->assertStatus(302) https://laravel.com/docs/5.6/http-tests#assert-status

or if you really want to check if the record is being deleted you could check the database in your test if the record is deleted $this->assertEquals(Comment::where('form_id', $userForm->id)->first(),null)

share|improve this answer

answered Mar 7 at 14:36

MrChrissssMrChrissss

14319

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  I changed my controller from redirect()->back to redirect()->route and changed the test to match and now it passes! Thank you for the tip!
  
  – Erik Willliams
  Mar 7 at 14:51
  

  
  
  
  

add a comment | 

0

You are using $response->assertSuccessful(); and redirecting user, I mean if your delete request successes it will return 302 redirect, change assertSuccessful() to assertStatus(302)

share|improve this answer

answered Mar 7 at 14:37

Nevermind23Nevermind23

225211

add a comment | 

Your Answer

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name

Email

Required, but never shown

StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55046189%2fhow-to-set-up-a-test-for-the-destroy-method-laravel-5-6%23new-answer', 'question_page');

);

Post as a guest

Name

Email

Required, but never shown

0

you could try to use assertRedirect https://laravel.com/docs/5.6/http-tests#assert-redirect

or use the status check:

$response->assertStatus(302) https://laravel.com/docs/5.6/http-tests#assert-status

or if you really want to check if the record is being deleted you could check the database in your test if the record is deleted $this->assertEquals(Comment::where('form_id', $userForm->id)->first(),null)

share|improve this answer

answered Mar 7 at 14:36

MrChrissssMrChrissss

14319

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  I changed my controller from redirect()->back to redirect()->route and changed the test to match and now it passes! Thank you for the tip!
  
  – Erik Willliams
  Mar 7 at 14:51
  

  
  
  
  

add a comment | 

0

you could try to use assertRedirect https://laravel.com/docs/5.6/http-tests#assert-redirect

or use the status check:

$response->assertStatus(302) https://laravel.com/docs/5.6/http-tests#assert-status

or if you really want to check if the record is being deleted you could check the database in your test if the record is deleted $this->assertEquals(Comment::where('form_id', $userForm->id)->first(),null)

share|improve this answer

answered Mar 7 at 14:36

MrChrissssMrChrissss

14319

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  I changed my controller from redirect()->back to redirect()->route and changed the test to match and now it passes! Thank you for the tip!
  
  – Erik Willliams
  Mar 7 at 14:51
  

  
  
  
  

add a comment | 

you could try to use assertRedirect https://laravel.com/docs/5.6/http-tests#assert-redirect

or use the status check:

$response->assertStatus(302) https://laravel.com/docs/5.6/http-tests#assert-status

or if you really want to check if the record is being deleted you could check the database in your test if the record is deleted $this->assertEquals(Comment::where('form_id', $userForm->id)->first(),null)

share|improve this answer

answered Mar 7 at 14:36

MrChrissssMrChrissss

14319

share|improve this answer

answered Mar 7 at 14:36

MrChrissssMrChrissss

14319

answered Mar 7 at 14:36

MrChrissssMrChrissss

14319

answered Mar 7 at 14:36

MrChrissssMrChrissss

14319

0

You are using $response->assertSuccessful(); and redirecting user, I mean if your delete request successes it will return 302 redirect, change assertSuccessful() to assertStatus(302)

share|improve this answer

answered Mar 7 at 14:37

Nevermind23Nevermind23

225211

add a comment | 

0

You are using $response->assertSuccessful(); and redirecting user, I mean if your delete request successes it will return 302 redirect, change assertSuccessful() to assertStatus(302)

share|improve this answer

answered Mar 7 at 14:37

Nevermind23Nevermind23

225211

add a comment | 

You are using $response->assertSuccessful(); and redirecting user, I mean if your delete request successes it will return 302 redirect, change assertSuccessful() to assertStatus(302)

share|improve this answer

answered Mar 7 at 14:37

Nevermind23Nevermind23

225211

share|improve this answer

answered Mar 7 at 14:37

Nevermind23Nevermind23

225211

answered Mar 7 at 14:37

Nevermind23Nevermind23

225211

answered Mar 7 at 14:37

Nevermind23Nevermind23

225211